optimization: Speed up pane switching by circumventing shell and tmux CLI when possible #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shell startup time is significant. For some reason, as @isaksamsten mentioned on alexghergh#16, switching is significantly slower in Fish shell than in other shells. I did some experimentation and found that `vim.fn.system(<string>)` is slow when the `shell` option is set to Fish. This change removes dependence on the shell entirely when switching tmux panes, since `system` doesn't use a shell when a table is provided in place of a string.
…ontrol This change cuts out the `tmux` CLI invocation when `disable_nav_when_zoomed = false`. This reordering was necessary to enable this workaround because the `and` operator is short-circuiting, and thus it will only evaluate the RHS if the LHS is `true`. Before, the slow function call was the LHS, and so it was being evaluated unconditionally, even when the significantly faster boolean check would have failed.
srithon
changed the title
disable_nav_when_zoomed = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim.fn.system(<string>)is slow when theshelloption is set to Fish. This change removes dependence on the shell entirely when switching tmux panes, sincesystemdoesn't use a shell when a table is provided in place of a string.tmuxat all, when a faster boolean check would rule out the conditional