[ui][fix] Application Menubar: Ensure Menubar occupies all of available height of the layout #2643
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parent layout The default font pointSize makes the menus feel a little detacheed compared to the home button next to it, increasing to 10 keeps it decent in the layout and also make it reasonable compared to the home icon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2643 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the
Menubarcomponent to ensure it fills the layout in terms of height.The change addresses an inconsistency where the MenuBar did not align with the Parent's dimensions.
Details of the change
Layout.fillHeightsets the Menubar component to take in the full available heightWhile the default font
pointSizemakes the menus feel a little detacheed compared to the home button next to it, increasing to 10 keeps it decent in the layout and also make it reasonable compared to the home icon.Appearence after the changes