Use PyBytes and not Unicode strings for IEC958 values #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tormod Volden <[email protected]>
Signed-off-by: Tormod Volden <[email protected]>
tormodvolden
force-pushed
the
iec958_pybytes
branch
from
27a642e to
3b720b5
Compare
The IEC958 structure was prepared, but not actually written. Signed-off-by: Tormod Volden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for #13.
the first commit is not strictly related but also needed to avoid hctltest1.py crashing with my audio devices, where some have info.count = 0. Let me know if more information is needed. I don't know if this is expected or if a warning should be issued.
I went for PyBytes instead of PyByteArray
for setting values, if the provided PyBytes value is shorter than the value, it will be zero-padded.
following the existing code style, no empty lines were inserted, but this could help readability
the third commit is not for fixing the crash, but for fixing set_tuple() to actually do anything for IEC958
I haven't changed the reference counting, which seems wrong to me in the original code as well. This would be a different issue.