Simplify initOptional function for clarity

[darseen]

Pull Request: Refactor initOptional Function

Description:

This pull request simplifies the initOptional function for improved clarity and conciseness. Key changes include:

• Simplified variable initialization using the logical OR operator.
• Maintained the same functionality with reduced redundancy.

Before:

initOptional(key, options, fallback = null) {
    let value = options[key];
    //Env variables names expected to be in SNAKE_CASE and uppercase
    let envKey = `AMADEUS_${key.replace(/[A-Z]/g, c => `_${c.toLowerCase()}`).toUpperCase()}`;
    if (value == undefined) { value = options[key]; } // unnecessary if check
    if (value == undefined) { value = process.env[envKey]; }
    if (value == undefined) { value = fallback; }
    return value;
  }

After:

initOptional(key, options, fallback = null) {
    // Env variables names expected to be in SNAKE_CASE and uppercase
    let envKey = `AMADEUS_${key.replace(/[A-Z]/g, c => `_${c.toLowerCase()}`).toUpperCase()}`;
    let value = options[key] || process.env[envKey] || fallback;
    return value;
}

Testing:

• Executed existing unit tests to ensure maintained functionality.

Impact

• Non-breaking changes that simplify code without altering behavior.

Reviewer

• Please review for readability and confirm no unintended side effects.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[minjikarin]

@darseen, Thank you so much for your contribution :)