Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic e2e tests #623

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Basic e2e tests #623

merged 4 commits into from
Jan 2, 2025

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jan 1, 2025

Partially addresses #244

Description of changes

Additional context

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 90143d9
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/67771353e219f4000856c6e2
😎 Deploy Preview https://deploy-preview-623--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95
Accessibility: 86
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit 90143d9
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/677713538267300008962b25

@keyserj keyserj force-pushed the basic-e2e-tests branch 5 times, most recently from c12a1af to 9aacd65 Compare January 2, 2025 19:48
@keyserj
Copy link
Collaborator Author

keyserj commented Jan 2, 2025

Wow that was a lot of work. Created these tickets for some issues that I ran into:

  • git-auto-commit-action triggers more CI but it shouldn't... created netlify (skip ci) request
  • for debugging it'd be nice to have playwright's snapshot diffs even if we used --update-snapshots to update then... created playwright issue: ability to save snapshot diffs with --update-snapshots
  • For some reason, Netlify preview/production hosts images based on nextjs device sizes next/image not properly sizing images vercel/next.js#44244 (comment), BUT local images are hosted based on the actual image size... So when the browser renders the images within the size of the viewport, the images end up compressing slightly different pixels, creating a significant diff... probably should file an issue for nextjs

@keyserj keyserj merged commit 428b5f4 into main Jan 2, 2025
10 checks passed
@keyserj keyserj deleted the basic-e2e-tests branch January 2, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant