Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix amp-pixel attribution reporting test failure #40220

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Jan 8, 2025

export function isAttributionReportingAllowed(doc) {
  return doc.featurePolicy?.allowedFeatures().includes('attribution-reporting');
}

Because isAttributionReportingAllowed is defined by whether the browser supports the attribution reporting api, with the new Chrome it flips to true. This PR fixes the test by no longer assuming it is off by default and forcing this test to test as if it is not supported. The supported case already exists.

@powerivq powerivq merged commit 87bb0ef into ampproject:main Jan 8, 2025
52 checks passed
@powerivq powerivq deleted the fix-pixel branch January 8, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants