drivers:rf-transceiver:ad9361:ad9361.c: Rx Tx FIR len must match #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiclaus
reviewed
Feb 16, 2022
|
Edited PR description to make sense and match commit description. Revert the changes if they are not appropriate. |
adrimbarean
changed the title
This is apparently not documented in any public document. Please see analogdevicesinc/ad936x-filter-wizard#43. This adds check to make sure the Rx and Tx number of FIR taps matches. Signed-off-by: Alexander Vickberg <[email protected]>
|
I have added a missing return |
|
It would be neat if this could be assigned to someone who can confirm/deny the need for this change. I have to confess that I kind of made this pull request to get this behavior of the chip confirmed/denied. |
|
@kylex2 , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is apparently not documented in any public document. Please see
analogdevicesinc/ad936x-filter-wizard#43. This adds check to make sure
the Rx and Tx number of FIR taps matches.
Signed-off-by: Alexander Vickberg [email protected]