Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: make_tb_path: Error for unset ADI_*_DIR #152

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

gastmaier
Copy link
Contributor

@gastmaier gastmaier commented Dec 10, 2024

PR Description

Add informative error for mandatory environment variable.
I would rather "hardcode" the depth on the entry Makefile (the one that we can obtain the current shell path),
and infer these variables for most users.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • New test (change that adds new test program and/or testbench)
  • Breaking change (has dependencies in other repositories/testbenches)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have ran all testbenches affected by this PR
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Errors on compilation/elaboration/simulation
  • I have set the verbosity level to none for the test program

Add informative error for mandatory environment variable.

Signed-off-by: Jorge Marques <[email protected]>
Copy link
Contributor

@IstvanZsSzekely IstvanZsSzekely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good suggestion!
Tested with Environment variables set and unset, both work as intended.

@gastmaier gastmaier merged commit a9797fe into main Dec 10, 2024
2 checks passed
@gastmaier gastmaier deleted the mk-error branch December 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants