Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize label version and add release id to OS model #2349

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Finalize label version and add release id to OS model #2349

merged 1 commit into from
Dec 23, 2024

Conversation

wagoodman
Copy link
Contributor

This PR changes the following aspects with regard to the v6 operating system table:

  • Searching for an OS combines the codename/label-version (otherwise it would not be clear that these separate fields are OR operations, not AND like everything else)
  • Searching for an OS can be done by name or release ID (from /etc/os-release), again as an OR operation
  • Operating system table now has the original release id (ol for oraclelinux)

@wagoodman wagoodman added the changelog-ignore Don't include this issue in the release changelog label Dec 23, 2024
@wagoodman wagoodman self-assigned this Dec 23, 2024
This was referenced Dec 23, 2024
Merged
Open
spiffcs
spiffcs approved these changes Dec 23, 2024
View reviewed changes
grype/db/v6/affected_package_store.go Show resolved Hide resolved
grype/db/v6/affected_package_store.go Show resolved Hide resolved
@wagoodman wagoodman merged commit 3baa3d2 into main Dec 23, 2024
10 checks passed
@wagoodman wagoodman deleted the release-id branch December 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffcs spiffcs spiffcs approved these changes

Assignees

@wagoodman wagoodman

Labels
changelog-ignore Don't include this issue in the release changelog
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @spiffcs