Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 #266

Merged
merged 40 commits into from
Jan 24, 2019
Merged

Release 2.0 #266

merged 40 commits into from
Jan 24, 2019

Conversation

vlad-zhukov
Copy link
Collaborator

@vlad-zhukov vlad-zhukov commented Apr 21, 2018

WIP, DON'T MERGE

Here we are working on a new major release according to the 2.0 roadmap. Use this branch as the base for new PRs.

@vlad-zhukov vlad-zhukov added this to the 2.0.0 milestone Apr 21, 2018
@vlad-zhukov vlad-zhukov self-assigned this Apr 21, 2018
@vlad-zhukov vlad-zhukov requested a review from andywer April 21, 2018 10:50
@vlad-zhukov vlad-zhukov mentioned this pull request Apr 21, 2018
17 tasks
dmitmel
dmitmel previously approved these changes Apr 21, 2018
*Deprecated. This feature will be removed soon. Use `match()` and `context.match` instead.*

The `context.fileType` is a mapping from MIME type (`application/javascript`, `text/css`, ...) to a regular expression used for matching filenames. You can find the default file types and the extensions they match [here](https://github.com/andywer/webpack-blocks/blob/master/packages/core/lib/defaultFileTypes.js).
Initially it will contain a `webpack` instance. If you are using [hooks](#hooks) you might want to put custom metadata into the context and use it in the `post` hook.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@andywer andywer changed the title Release 2.0 Remove deprecated features Apr 21, 2018
@vlad-zhukov vlad-zhukov changed the title Remove deprecated features Release 2.0 Apr 21, 2018
andywer
andywer previously approved these changes Apr 21, 2018
@andywer
Copy link
Owner

andywer commented Apr 21, 2018

I can't tell you how much I like this PR 😊

bildschirmfoto 2018-04-21 um 16 31 04

@andywer
Copy link
Owner

andywer commented Apr 21, 2018

PS: Changed the PR title.

@andywer
Copy link
Owner

andywer commented Apr 21, 2018

Did someone change the PR title again? "Release 2.0" is not a good title for this PR...

@vlad-zhukov
Copy link
Collaborator Author

vlad-zhukov commented Apr 21, 2018

This is a tracking PR of all v2 changes 😁 Don't bother reviewing it for now, it will be ready when all 2.0.0 milestone are done!

All thanks for removing deprecated stuff should go to @dmitmel in #260!

@andywer
Copy link
Owner

andywer commented Apr 21, 2018

@vlad-zhukov Why not merge this already as "Remove deprecated features"? Multiple short PRs are easier to review and comprehend than few large ones :)

I think if we add new code in this PR, too, than it will get quite messy, because of the large number of changed lines.

@vlad-zhukov
Copy link
Collaborator Author

Because these changes have been already reviewed and merged into this branch. I am not going to push commits into this branch directly, only through PRs! 😏

@andywer
Copy link
Owner

andywer commented Apr 21, 2018

Ahhh, now I get it 😉

I would suggest, though, that we either
a) close this PR, just keep merging into this release branch and later open the PR when we are ready to merge
or
b) Add in BIG letters to the title: Release 2.0. WIP. DON'T MERGE YET.

So no one can accidentally merge this prematurely. You know, accidents happen... 😅
We could also create a Version 2.0 milestone and add all PRs / issues to it, so we can easily track them.

Thoughts?

@vlad-zhukov vlad-zhukov changed the title Release 2.0 [WIP] Release 2.0 Apr 21, 2018
@vlad-zhukov
Copy link
Collaborator Author

I would like to have this PR opened to keep track of certain stuff. Added a WIP note, is it ok?

And I've already created a 2.0.0 milestone earlier today.

Copy link
Owner

@andywer andywer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a release PR and will not be merged until all its changes are done.

Blocking the PR for now.

@andywer
Copy link
Owner

andywer commented Apr 21, 2018

Ok. Just did a "request changes" to prevent merging for now.

Btw, thank you guys for your efforts! You are really moving the project forward 😊

@vlad-zhukov
Copy link
Collaborator Author

Ready for the 1st alpha I guess!
@andywer would you like to merge this or release a new version from this branch?

@andywer
Copy link
Owner

andywer commented Jun 25, 2018

Sure! Can do, but not before tonight 😉

@andywer
Copy link
Owner

andywer commented Jun 25, 2018

Sorry, didn't realize it was a question... 😅

Let's publish from this feature branch for the alpha release.

@andywer
Copy link
Owner

andywer commented Jun 25, 2018

Published as v2.0.0-alpha, npm tag next. Install as npm i --save-dev webpack-blocks@next.

@Lavoaster

@LavaToaster
Copy link

Thanks @andywer @vlad-zhukov

Upgraded this and to webpack 4.0 the other day and it all went pretty smooth, all I really needed to do was add the mode block to my config. So looks good here right now.

@vpsouza
Copy link

vpsouza commented Jul 11, 2018

@Lavoaster can you help me with a sample config for webpack 4.0?

@dmitmel
Copy link
Contributor

dmitmel commented Jul 11, 2018

@vpsouza Do you mean a sample config with webpack-blocks? If so, I have one in my project. It's a refactored version of the webpack config from create-react-app. Although it's not perfect and uses webpack-blocks v1.0, you may find it useful.

@dmitmel
Copy link
Contributor

dmitmel commented Jul 11, 2018

@andywer @vlad-zhukov @zcei BTW, I had an idea of creating a preset with blocks for React apps

@andywer
Copy link
Owner

andywer commented Jul 11, 2018

@dmitmel Sure. Feel free to share it in the gitter chat room :)

@andywer andywer merged commit 300362f into master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants