This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Skip emitting provided inner classes redundantly in processUnprovidedTypes()
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teppeis
force-pushed
the
skip-provided-symbol
branch
from
50b5d4b to
28cc752
Compare
teppeis
force-pushed
the
skip-provided-symbol
branch
from
28cc752 to
2995b37
Compare
teppeis
force-pushed
the
skip-provided-symbol
branch
from
2995b37 to
340d658
Compare
teppeis
force-pushed
the
skip-provided-symbol
branch
from
340d658 to
cb78937
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #822
If an inner class has a non-class-like prop (ex. enum) and the prop is referenced from other jsdoc, the prop is emitted duplicately each time it is referred.
There are the examples in closure-library:
Also added a test case for
goog.debug.Tracethat has a special structure related this handling.