Add KelvinPerMinute to TemperatureChangeRateUnit #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewmeservy
commented
Oct 17, 2024
andrewmeservy
commented
- Add KelvinPerMinute to TemperatureChangeRateUnit
- Add "pause" at end of generate-code.bat so the cmd window does not close immediately, allowing devs to inspect any errors that may have occurred during the command execution.
|
Thanks, looks perfect! Nuget should be out in 30 minutes or so. |
angularsen
pushed a commit
that referenced
this pull request
Dec 7, 2024
added the following units to TemperatureChangeRate: DegreeFahrenheitPerMinute DegreeFahrenheitPerSecond DegreeKelvinPerSecond DegreeCelsiusPerHour DegreeKelvinPerHour DegreeFahrenheitPerHour After reviewing the unit tests I came to the conclusion that the recently added (#1429) unit DegreeKelvinPerMinute had a wrong conversion. I checked that for example here: https://www.unitsconverters.com/en/Rate-Of-Temperature-Change-Conversions/Measurement-1189 and also here: https://www.quora.com/Why-is-32-not-used-when-converting-per-degree-Celsius-C-1-to-per-degree-Fahrenheit-F-1
|
@angularsen I don't believe this has been carried over to |
|
would def appreciate this being included in future versions, and really appreciate David-HH-Dev fixing the conversion calculation :) |
|
@lipchev It will eventually be merged in along with everything else from master to v6, when I have enough time and energy to deal with all the merge conflits 😄 |
|
If anyone is eager to get it into v6 sooner, you can do a separate PR targeting |
|
Merged into V6 branch, nuget should be out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.