NF: replace mid by noteTypeId
#17771
Open
+45
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
requested changes
Jan 8, 2025
Comment on lines
+83
to
+84
| noteTypeId = note.notetypeId | ||
| notetype = col.notetypes.get(noteTypeId)!! // not in libAnki |
There was a problem hiding this comment.
what does upstream do here? [in this class]
| * @param key the first field of a note | ||
| * @return a list of duplicate notes | ||
| */ | ||
| public fun findDuplicateNotes( | ||
| mid: Long, | ||
| noteTypeId: Long, |
There was a problem hiding this comment.
| @@ -202,15 +202,15 @@ public class AddContentApi( | |||
|
|
|||
| /** | |||
| * Find all existing notes in the collection which have mid and a duplicate key | |||
| * @param mid model id | |||
| * @param noteTypeId model id | |||
There was a problem hiding this comment.
Explanation was not updated
| @@ -202,15 +202,15 @@ public class AddContentApi( | |||
|
|
|||
| /** | |||
| * Find all existing notes in the collection which have mid and a duplicate key | |||
| @@ -495,10 +495,10 @@ public class AddContentApi( | |||
|
|
|||
| /** | |||
| * Get the name of the model which has given ID | |||
There was a problem hiding this comment.
Lots of 'model' in this file. Not sure if intentional
lukstbit
added
the
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.