feat: listen for the transfer success event #1490
Conversation
euharrison
changed the title
| }; | ||
| }, deps); | ||
| }, [event]); |
There was a problem hiding this comment.
I lost many hours debugging until realizing this dependencies was the issue 😢
Maybe we should enable the "react-hooks/exhaustive-deps": "warn" and, if you don't want to use, at least you need to add the lint ignore comment
What do you think?
There was a problem hiding this comment.
Can we concatenate this [event] with the former deps array, if it's not empty?
There was a problem hiding this comment.
we don't need the deps anymore, because the function is saved on the ref, so you are free to pass anything, even a new function everytime
| hash: string | ||
| ): Promise<WrapperTransaction> => { | ||
| // indexer only accepts the hash as lowercase | ||
| return (await api.apiV1ChainWrapperTxIdGet(hash.toLowerCase())).data; |
There was a problem hiding this comment.
I've created a small utility function that might be useful here :) utils/address.ts@sanitizeAddress
| }; | ||
| }, deps); | ||
| }, [event]); |
| }; | ||
| }, deps); | ||
| }, [event]); |
There was a problem hiding this comment.
Can we concatenate this [event] with the former deps array, if it's not empty?
| clearPendingNotifications(id); | ||
| const storedTx = searchAllStoredTxByHash(tx.hash); | ||
| const storedTx = searchAllStoredTxByHash(e.detail.tx[0].hash); |
There was a problem hiding this comment.
Please check if what you want is not the tx[0].innerTxHashes[0]
There was a problem hiding this comment.
Validated. The tx[0].hash is correct. We don't have the innerTxHashes on the event object, and we are creating the stored tx with the txs[0].hash from response, not the txs[0].innerTxHashes[0]
Listen for the transfer
Successevent and apply it to the notifications and transaction pageAlso, enable the watcher for cases where the transaction delays and the user closes the browser
Closes #1428
Closes #1485
Screen.Recording.2025-01-09.at.15.27.14.mov