Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring Release-Please to create releases for Apps / Packages #1502

Merged
merged 12 commits into from
Jan 14, 2025

Conversation

pedrorezende
Copy link
Collaborator

@pedrorezende pedrorezende commented Jan 11, 2025

This PR improves the whole CI for the namada-interface monorepo. The main changes are listed below:

  • Release Please runs when any PR is merged to main, creating chore PRs bumping the version of the following packages: apps/namadillo, apps/extension, package/sdk, package/types
  • When the version PR is merged to main, Release Please creates a new release containing the changelog + built files for every package changed.
  • Refactored some actions to reuse some code
  • We won't run Firefox build anymore after a new PR is open, only on the release process

Testing this PR

There's no straightforward way to fully test this PR. I was working in a temporary test branch with some main changes I list below. Forks won't work.

  1. On release-please-config.json , add "draft": true to the config.
  2. On .github/workflows/release.yml , change main to the name of the test branch and also add the following config release-please-action:
    steps:
      - uses: googleapis/release-please-action@v4
        id: release
+        with:
+         target-branch: name-of-your-test-branch
  1. Release please will probably create a bunch of new PRs, so take some care with that if you want to test

Next Steps

  • Automatically release packages to NPM registry
  • Notify new releases on Discord

@pedrorezende pedrorezende force-pushed the feat/release-please branch 7 times, most recently from 2394860 to 6219f4c Compare January 11, 2025 23:13
@pedrorezende pedrorezende changed the title WIP: Configuring Release-Please to create releases on Namadillo Configuring Release-Please to create releases for Apps / Packages Jan 14, 2025
Copy link
Collaborator

@euharrison euharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✅

@pedrorezende pedrorezende merged commit 8a01328 into main Jan 14, 2025
7 checks passed
@pedrorezende pedrorezende deleted the feat/release-please branch January 14, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants