fix: fix fee component on transfers #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
changed the title
pedrorezende
requested changes
Jan 15, 2025
| @@ -47,6 +47,8 @@ export const TransferDestination = ({ | |||
| openChainSelector, | |||
| openProviderSelector, | |||
| }: TransferDestinationProps): JSX.Element => { | |||
| const isExternalDestination = !!openChainSelector; | |||
There was a problem hiding this comment.
I'm not sure this is the correct way of verifying that we can define the fee token. I think we should verify if the transfer is coming from Namada instead
There was a problem hiding this comment.
yeah, agreed. I added the prop changeFeeEnabled to have a better control over it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txKindto transfer query keycloses #1501
closes #1492