Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing Github configs overrides to avoid upgrade issues #1565

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: removing Github configs overrides to avoid upgrade issues #1565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/namadillo/public/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@
#masp_indexer_url = ""
#localnet_enabled = false

github_chain_registry_base_url = "https://raw.githubusercontent.com/anoma/namada-chain-registry/refs/heads/main"
github_namada_interface_url = "https://raw.githubusercontent.com/anoma/namada-interface/refs/heads/main"
14 changes: 3 additions & 11 deletions apps/namadillo/src/atoms/integrations/atoms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
ChainRegistryEntry,
RpcStorage,
} from "types";
import { githubNamadaChainRegistryBaseUrl } from "urls";
import {
addLocalnetToRegistry,
createIbcTx,
Expand Down Expand Up @@ -141,21 +142,12 @@ export const ibcChannelsFamily = atomFamily((ibcChainName?: string) =>
...queryDependentFn(async () => {
invariant(chainSettings.data, "No chain settings");
invariant(ibcChainName, "No IBC chain name");
invariant(
config.data?.github_chain_registry_base_url,
"No github_chain_registry_base_url was provided on config.toml"
);
return fetchIbcChannelFromRegistry(
chainSettings.data.chainId,
ibcChainName,
config.data?.github_chain_registry_base_url
githubNamadaChainRegistryBaseUrl
);
}, [
chainSettings,
config,
!!ibcChainName,
!!config.data?.github_chain_registry_base_url,
]),
}, [chainSettings, config, !!ibcChainName]),
};
})
);
Expand Down
2 changes: 0 additions & 2 deletions apps/namadillo/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ export type SettingsTomlOptions = {
masp_indexer_url?: string;
rpc_url?: string;
localnet_enabled?: boolean;
github_chain_registry_base_url?: string;
github_namada_interface_url?: string;
};

export type ChainParameters = {
Expand Down
6 changes: 6 additions & 0 deletions apps/namadillo/src/urls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
export const DISCORD_URL = "https://discord.com/invite/namada";
export const TWITTER_URL = "https://twitter.com/namada";

export const githubNamadaChainRegistryBaseUrl =
"https://raw.githubusercontent.com/anoma/namada-chain-registry/refs/heads/main";

export const githubNamadaInterfaceBaseUrl =
"https://raw.githubusercontent.com/anoma/namada-interface/refs/heads/main";
Loading