Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of transactions' results #4182

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Dec 13, 2024

Describe your changes

Closes #4107.

Reworked the display of a transaction's result to address the followings:

  • We now display the actual result code and info in case of a wrapper failure to convey more information
  • We display the gas consumed only if the entire batch was successful, in all the other cases this value cannot be relied upon

Updated the display of a dry-run result to improve formatting and align it with the display of an actual tx result.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@grarco grarco marked this pull request as ready for review December 13, 2024 15:19
@grarco grarco force-pushed the grarco/tx-result-display branch from a785081 to 4b07807 Compare December 13, 2024 15:19
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.23377% with 26 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (ea76477) to head (7d52518).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 50.00% 13 Missing ⚠️
crates/sdk/src/tx.rs 74.50% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4182   +/-   ##
=======================================
  Coverage   74.46%   74.47%           
=======================================
  Files         341      342    +1     
  Lines      107710   107773   +63     
=======================================
+ Hits        80207    80264   +57     
- Misses      27503    27509    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added backport-libs-0.46 Backport libraries to 0.46 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass and removed breaking:client labels Dec 16, 2024
mergify bot added a commit that referenced this pull request Dec 16, 2024
@mergify mergify bot merged commit 78ea550 into main Dec 16, 2024
24 of 25 checks passed
@mergify mergify bot deleted the grarco/tx-result-display branch December 16, 2024 10:32
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 4b07807)
mergify bot added a commit that referenced this pull request Dec 16, 2024
Improve display of transactions' results (backport #4182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better display of transactions' results
2 participants