-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve display of transactions' results #4182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
force-pushed
the
grarco/tx-result-display
branch
from
December 13, 2024 15:19
a785081
to
4b07807
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4182 +/- ##
=======================================
Coverage 74.46% 74.47%
=======================================
Files 341 342 +1
Lines 107710 107773 +63
=======================================
+ Hits 80207 80264 +57
- Misses 27503 27509 +6 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Dec 16, 2024
tzemanovic
added
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
and removed
breaking:client
labels
Dec 16, 2024
3 tasks
mergify bot
added a commit
that referenced
this pull request
Dec 16, 2024
Improve display of transactions' results (backport #4182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
SDK
UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4107.
Reworked the display of a transaction's result to address the followings:
code
andinfo
in case of a wrapper failure to convey more informationUpdated the display of a
dry-run
result to improve formatting and align it with the display of an actual tx result.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo