Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MASP inverse conversions #4193

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Test MASP inverse conversions #4193

merged 3 commits into from
Dec 30, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Dec 17, 2024

Describe your changes

Adds tests for the MASP inverse conversions.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (c993d59) to head (f0e36a7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
+ Coverage   74.58%   74.62%   +0.04%     
==========================================
  Files         342      342              
  Lines      108433   108554     +121     
==========================================
+ Hits        80876    81011     +135     
+ Misses      27557    27543      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco force-pushed the grarco/test-inverse-conversions branch from 5fca376 to e16fb8c Compare December 19, 2024 15:44
grarco added a commit that referenced this pull request Dec 19, 2024
@grarco grarco marked this pull request as ready for review December 19, 2024 15:52
@grarco grarco requested a review from batconjurer December 19, 2024 16:41
@grarco grarco added the backport-libs-0.46 Backport libraries to 0.46 maintenance branch label Dec 23, 2024
@brentstone
Copy link
Collaborator

Should this be merged now?

@grarco
Copy link
Collaborator Author

grarco commented Dec 25, 2024

Should this be merged now?

We are blocked by 4146

grarco added a commit that referenced this pull request Dec 30, 2024
@grarco grarco force-pushed the grarco/test-inverse-conversions branch from 43974e6 to 878efa1 Compare December 30, 2024 15:07
@grarco grarco removed the backport-libs-0.46 Backport libraries to 0.46 maintenance branch label Dec 30, 2024
@grarco grarco force-pushed the grarco/test-inverse-conversions branch from 878efa1 to f0e36a7 Compare December 30, 2024 15:17
@grarco grarco added backport-libs-0.46 Backport libraries to 0.46 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Dec 30, 2024
@mergify mergify bot merged commit b579d49 into main Dec 30, 2024
25 checks passed
@mergify mergify bot deleted the grarco/test-inverse-conversions branch December 30, 2024 15:58
mergify bot pushed a commit that referenced this pull request Dec 30, 2024
(cherry picked from commit f0e36a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants