-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test MASP inverse conversions #4193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4193 +/- ##
==========================================
+ Coverage 74.58% 74.62% +0.04%
==========================================
Files 342 342
Lines 108433 108554 +121
==========================================
+ Hits 80876 81011 +135
+ Misses 27557 27543 -14 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/test-inverse-conversions
branch
from
December 19, 2024 15:44
5fca376
to
e16fb8c
Compare
batconjurer
approved these changes
Dec 20, 2024
grarco
added
the
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
label
Dec 23, 2024
Should this be merged now? |
We are blocked by 4146 |
grarco
force-pushed
the
grarco/test-inverse-conversions
branch
from
December 30, 2024 15:07
43974e6
to
878efa1
Compare
grarco
removed
the
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
label
Dec 30, 2024
grarco
force-pushed
the
grarco/test-inverse-conversions
branch
from
December 30, 2024 15:17
878efa1
to
f0e36a7
Compare
grarco
added
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
labels
Dec 30, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-0.46
Backport libraries to 0.46 maintenance branch
MASP
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds tests for the MASP inverse conversions.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo