Skip to content

Commit

Permalink
[nxos_bgp_global] - Add fix for local as options (#885)
Browse files Browse the repository at this point in the history 
* add fix for local as options

* remove debug statements

* chore: auto fixes from pre-commit.com hooks

* fix argspec

* update other local_as

* chore: auto fixes from pre-commit.com hooks

* fix docs

* config and argspec

* add UT and changelog

* chore: auto fixes from pre-commit.com hooks

* check changes

* chore: auto fixes from pre-commit.com hooks

* remove debug statement

* fix tests

* remove debug statements

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
@KB-perByte @pre-commit-ci
KB-perByte and pre-commit-ci[bot] authored Aug 18, 2024
1 parent 9f55a32 commit 95e11a8
Show file tree
Hide file tree
Showing 8 changed files with 2,857 additions and 16 deletions.
6 changes: 6 additions & 0 deletions changelogs/fragments/fix_local_as.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
minor_changes:
- nxos_bgp_global - Deprecate local_as with local_as_config which
supports more configuration attributes, under neighbor.
doc_changes:
- nxos_bgp_global - Marks local_as under neighbor deprecated, and some documentation corrections.
223 changes: 218 additions & 5 deletions docs/cisco.nxos.nxos_bgp_global_module.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ Parameters
</ul>
</td>
<td>
<div>Activiate graceful-shutdown.</div>
<div>Activate graceful-shutdown.</div>
</td>
</tr>

Expand Down Expand Up @@ -1271,7 +1271,7 @@ Parameters
<td>
</td>
<td>
<div>Neighbor specific descripion.</div>
<div>Neighbor specific description.</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -1519,8 +1519,112 @@ Parameters
</td>
<td>
<div>Specify the local-as number for the eBGP neighbor.</div>
<div><b>Deprecated</b>, Use local_as_config instead, the facts would always render local_as information as a part of local_as_config as_number</div>
<div>This option has been deprecated and will be removed in a release after 2027-01-01.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="5">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>local_as_config</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">dictionary</span>
</div>
</td>
<td>
</td>
<td>
<div>Local Autonomous System Number options.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="4">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>as_number</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">string</span>
</div>
</td>
<td>
</td>
<td>
<div>Set Specify the local-as number for the eBGP neighbor.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="4">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>dual_as</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Connect using either the local-as number or the real as.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="4">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>no_prepend</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Do not prepend the local-as number to updates from the eBGP neighbor.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="4">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>replace_as</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Prepend only the local-as number to updates to eBGP neighbor.</div>
</td>
</tr>

<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
Expand Down Expand Up @@ -1597,7 +1701,7 @@ Parameters
<td>
</td>
<td>
<div>Behaviour in low memory situations.</div>
<div>Behavior in low memory situations.</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -3371,7 +3475,7 @@ Parameters
<td>
</td>
<td>
<div>Neighbor specific descripion.</div>
<div>Neighbor specific description.</div>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -3632,8 +3736,117 @@ Parameters
</td>
<td>
<div>Specify the local-as number for the eBGP neighbor.</div>
<div><b>Deprecated</b>, Use local_as_config instead, the facts would always render local_as information as a part of local_as_config as_number</div>
<div>This option has been deprecated and will be removed in a release after 2027-01-01.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="4">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>local_as_config</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">dictionary</span>
</div>
</td>
<td>
</td>
<td>
<div>Local Autonomous System Number options.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="3">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>as_number</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">string</span>
</div>
</td>
<td>
</td>
<td>
<div>Set Specify the local-as number for the eBGP neighbor.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="3">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>dual_as</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Connect using either the local-as number or the real as.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="3">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>no_prepend</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Do not prepend the local-as number to updates from the eBGP neighbor.</div>
</td>
</tr>
<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
<td colspan="3">
<div class="ansibleOptionAnchor" id="parameter-"></div>
<b>replace_as</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">boolean</span>
</div>
</td>
<td>
<ul style="margin: 0; padding: 0"><b>Choices:</b>
<li>no</li>
<li>yes</li>
</ul>
</td>
<td>
<div>Prepend only the local-as number to updates to eBGP neighbor.</div>
</td>
</tr>

<tr>
<td class="elbow-placeholder"></td>
<td class="elbow-placeholder"></td>
Expand Down Expand Up @@ -3714,7 +3927,7 @@ Parameters
<td>
</td>
<td>
<div>Behaviour in low memory situations.</div>
<div>Behavior in low memory situations.</div>
</td>
</tr>
<tr>
Expand Down
Loading

0 comments on commit 95e11a8

Please sign in to comment.