Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Config module #768

Merged
merged 11 commits into from
Oct 25, 2023
Merged

Bugfix: Config module #768

merged 11 commits into from
Oct 25, 2023

Conversation

ashwini-mhatre
Copy link
Collaborator

@ashwini-mhatre ashwini-mhatre commented Oct 5, 2023 •
edited by NilashishC
Loading

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 5, 2023 11:18 — with GitHub Actions Inactive
@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 5, 2023 11:19 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3f021933664b4254b5aea75687a804c7

✔️ ansible-galaxy-importer SUCCESS in 5m 00s
✔️ build-ansible-collection SUCCESS in 8m 52s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 39s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 30s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 42s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 40s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 35m 38s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 18s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 42m 03s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 46s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 37s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 35m 12s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 18s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 33m 01s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 33m 59s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 28s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 39m 22s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 32s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 23s

@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 10, 2023 13:59 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 10, 2023 14:01 Inactive
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #768 (63182c6) into main (f6abf6b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   84.99%   85.01%   +0.01%     
==========================================
  Files         211      211              
  Lines       18213    18230      +17     
==========================================
+ Hits        15481    15498      +17     
  Misses       2732     2732

see 1 file with indirect coverage changes

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3ff3a1d9f24f4691aef6821a19f21083

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 8m 36s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 39s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 54s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 54s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 06s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 34m 42s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 34m 23s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 41m 14s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 27s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 35s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 37s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 06s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 29s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 20s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 32m 54s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 39m 57s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 32m 29s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 14s

@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 11, 2023 07:57 — with GitHub Actions Inactive
@ashwini-mhatre ashwini-mhatre changed the title WIP:Fix config module Fix config module Oct 11, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 11, 2023 07:58 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/617d5f3edfd941adacea548bed0e0a12

✔️ ansible-galaxy-importer SUCCESS in 3m 31s
✔️ build-ansible-collection SUCCESS in 8m 42s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 25s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 44s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario03 SUCCESS in 35m 16s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 44s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 37m 05s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 33m 40s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 40m 18s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 13s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 40s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 07s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 42s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 07s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 37m 40s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 20s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 40m 20s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 11s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 12s

@ashwini-mhatre ashwini-mhatre changed the title Fix config module Bugfix: Config module Oct 11, 2023
@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 12, 2023 12:41 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 12, 2023 12:43 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 12, 2023 12:47 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0e8462ad1d194ccc92764cc141e0ef42

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 8m 46s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 28m 23s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 41s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 52s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 58s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 36m 15s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 38m 22s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 45m 48s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 02s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 33m 58s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 49s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 09s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 24s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 FAILURE in 32m 45s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 34m 11s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 39m 12s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 32m 01s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 18s

@NilashishC NilashishC temporarily deployed to ack October 12, 2023 14:19 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3665778f57264467a63dde1888510a50

✔️ ansible-galaxy-importer SUCCESS in 5m 25s
✔️ build-ansible-collection SUCCESS in 8m 38s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 28m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 27s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 37m 03s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 09s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 33m 49s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 27s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 40m 37s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 23s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 33m 28s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 43s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 46s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 56s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 FAILURE in 32m 25s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 12s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 39m 51s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 32m 07s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 23s

@Qalthos
Copy link
Contributor

Qalthos commented Oct 13, 2023

I am real excited to see that some of these restrictions are finally being dropped.

@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 16, 2023 13:15 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 16, 2023 13:16 Inactive
@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 16, 2023 13:29 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 16, 2023 13:29 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b3bd1c6941f749d7992b6d050479bb3e

✔️ ansible-galaxy-importer SUCCESS in 5m 20s
✔️ build-ansible-collection SUCCESS in 8m 41s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 32s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 16s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 10s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 05s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 33m 39s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 40m 46s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 00s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 58s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 27s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 RETRY_LIMIT in 9m 18s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 29s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 FAILURE in 33m 37s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 00s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 40m 12s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 RETRY_LIMIT in 9m 19s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 16s

@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 17, 2023 06:29 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 17, 2023 06:30 Inactive
@ashwini-mhatre ashwini-mhatre temporarily deployed to ack October 17, 2023 07:03 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/728ec521a49a4f6a828915ae07b01ccd

✔️ ansible-galaxy-importer SUCCESS in 5m 04s
✔️ build-ansible-collection SUCCESS in 8m 38s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 30m 12s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 25s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 40s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 54s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 33m 57s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 40m 31s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 30s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 58s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 49s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 59s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 27s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 04s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 33m 33s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 39m 57s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 41s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 05s

@NilashishC NilashishC temporarily deployed to ack October 25, 2023 07:23 — with GitHub Actions Inactive
@NilashishC NilashishC requested a review from roverflow October 25, 2023 07:24
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/00c40423e1ae42228b2cd05f886f1c45

✔️ ansible-galaxy-importer SUCCESS in 5m 31s
✔️ build-ansible-collection SUCCESS in 8m 44s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 41s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 29m 10s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 36s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario04 FAILURE in 27m 44s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 54s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 39s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 44m 35s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 27m 52s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 34m 47s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 34m 17s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 40m 01s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 31m 49s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario01 SUCCESS in 34m 58s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario02 SUCCESS in 32m 34s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario03 SUCCESS in 41m 07s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable213-scenario04 SUCCESS in 31m 23s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 16s

@ashwini-mhatre ashwini-mhatre merged commit 6cf40f8 into ansible-collections:main Oct 25, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NilashishC NilashishC NilashishC approved these changes

@Qalthos Qalthos Qalthos approved these changes

@KB-perByte KB-perByte Awaiting requested review from KB-perByte

@roverflow roverflow Awaiting requested review from roverflow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_config does not allow block replace when providing src rather than lines
4 participants
@ashwini-mhatre @Qalthos @NilashishC @roverflow