fix None value handling in l2 interfaces #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAYUSH2091
changed the title
NilashishC
approved these changes
Jan 9, 2025
KB-perByte
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes handling of "none" value in allowed_vlans configuration for nxos_l2_interfaces module. Currently, when configuring allowed_vlans: none with state: replaced, the module either fails with int conversion error or removes the VLAN configuration entirely, making the port allow all VLANs instead of setting it to none.
fixed #910
ISSUE TYPE
COMPONENT NAME
cisco.nxos.nxos_l2_interfaces