Fix downstream tests #922
Merged
Fix downstream tests #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilashishC
reviewed
Jan 10, 2025
NilashishC
reviewed
Jan 10, 2025
NilashishC
requested changes
Jan 10, 2025
There was a problem hiding this comment.
I think we should wrap all task/main.yml of all such failing target roles with a var, let's say "nxos_skip_marked" and ask @komaldesai13 to set this var to true in downstream inventory.
This change is temporary and I really do not want to touch the existing logic.
NilashishC
reviewed
Jan 10, 2025
tests/integration/targets/nxos_vrf_address_family/tasks/cli.yaml
Outdated
Show resolved
Hide resolved
NilashishC
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix downstream tests for vrf_address_family, vrf_interfaces
ISSUE TYPE