Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lag_interfaces - Fix bug where lag interfaces was not erroring on command failure #923

Merged
merged 3 commits into from
Jan 15, 2025
Merged

lag_interfaces - Fix bug where lag interfaces was not erroring on command failure #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eaa92b
lag_interfaces - Fix bug where lag interfaces was not erroring on com…
sean-m-sullivan Jan 14, 2025
3eee404
linting
sean-m-sullivan Jan 14, 2025
3b56443
added pr to changelog
sean-m-sullivan Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/lag_interfaces_error.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- "lag_interfaces - Fix bug where lag interfaces was not erroring on command failure. (https://github.com/ansible-collections/cisco.nxos/pull/923)"
2 changes: 1 addition & 1 deletion galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ readme: README.md
repository: https://github.com/ansible-collections/cisco.nxos
issues: https://github.com/ansible-collections/cisco.nxos/issues
tags: [cisco, nxos, networking, nxapi, netconf]
version: 9.2.1
version: 9.2.2-devel
2 changes: 2 additions & 0 deletions plugins/module_utils/network/nxos/config/lag_interfaces/lag_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ def execute_module(self):
err_str = item
if err_str.lower().startswith("cannot add"):
self._module.fail_json(msg=err_str)
elif err_str.lower().startswith("command failed"):
self._module.fail_json(msg=err_str)
result["changed"] = True

if self.state in self.ACTION_STATES:
Expand Down
Loading