Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up test namespace #852

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Clean up test namespace #852

merged 1 commit into from
Jan 17, 2025

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Jan 17, 2025

SUMMARY

The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@gravesm
Clean up test namespace
482d2fb 
The helm_set_values test target did not clean up its namespace which is
leading to unstable tests in the k8s_drain target.
@gravesm gravesm mentioned this pull request Jan 17, 2025
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/90899d90cab1495b976a621a4c167adf

✔️ ansible-galaxy-importer SUCCESS in 4m 56s
✔️ build-ansible-collection SUCCESS in 5m 27s

@yurnov yurnov mentioned this pull request Jan 16, 2025
Open
32 tasks
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c41838e2dd954b5a87f8094ee3bdaac3

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 5m 20s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9f60b15 into ansible-collections:main Jan 17, 2025
57 of 58 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 17, 2025 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/9f60b151bac9554eb4ec852f6642c205f130ec60/pr-852

Backported as #853

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 17, 2025
@gravesm @patchback
Clean up test namespace (#852)
03614bc 
SUMMARY

The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Yuriy Novostavskiy
(cherry picked from commit 9f60b15)
@patchback Patchback
Copy link

patchback bot commented Jan 17, 2025 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/9f60b151bac9554eb4ec852f6642c205f130ec60/pr-852

Backported as #854

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 17, 2025
Merged
patchback bot pushed a commit that referenced this pull request Jan 17, 2025
@gravesm @patchback
Clean up test namespace (#852)
78ce135 
SUMMARY

The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Yuriy Novostavskiy
(cherry picked from commit 9f60b15)
@patchback patchback bot mentioned this pull request Jan 17, 2025
Merged
@gravesm gravesm deleted the clean-up-ns branch January 17, 2025 14:54
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 17, 2025
@patchback
Clean up test namespace (#852) (#853)
9267e03 
This is a backport of PR #852 as merged into main (9f60b15).
SUMMARY

The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 17, 2025
@patchback
Clean up test namespace (#852) (#854)
8cee9fd 
This is a backport of PR #852 as merged into main (9f60b15).
SUMMARY

The helm_set_values test target did not clean up its namespace which is leading to unstable tests in the k8s_drain target.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@yurnov yurnov yurnov approved these changes

Assignees
No one assigned
Labels
backport-3 backport-5 mergeit skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gravesm @yurnov @alinabuzachis