Add Group Resource

[GomathiselviS]

This PR adds group resource. Refer https://issues.redhat.com/browse/ACA-1158

terraform {
  required_providers {
    aap = {
      source = "ansible/aap"
    }
  }
}

provider "aap" {
  host     = "https://controller.xxx.xyz/"
  username = "xxxx"
  password = "xxxx"
  insecure_skip_verify = true
}

resource "aap_group" "sample" {
  inventory_id = 1
  name = "tf_group" 
  variables = jsonencode({"ansible_network_os": "ios"})
}

[abikouo]

LGTM, Just lint issues to fix

[GomathiselviS]

LGTM, Just lint issues to fix

Hi @abikouo Can you help me fix this lint failure. The failure happens in the job_resource_test.go

[gravesm]

Hi @abikouo Can you help me fix this lint failure. The failure happens in the job_resource_test.go

This seems to me like a bad linting error. It's claiming that lines 450-480 of job_resource_test.go are duplicates of lines 515-545. They are not, as one is testing idempotence without triggers and the other is testing idempotence with triggers. They are very similar, but clearly not duplicates.

IMO, running anything more than just go fmt on tests is not worth it, since tests often are written in ways that code analyzers are likely to flag. I would look at the linters we have running and see if there's a configuration you can use that gets it to ignore this. I'm not sure why this wasn't flagged in the job resource PR.

[GomathiselviS]

Hi @abikouo Can you help me fix this lint failure. The failure happens in the job_resource_test.go

This seems to me like a bad linting error. It's claiming that lines 450-480 of job_resource_test.go are duplicates of lines 515-545. They are not, as one is testing idempotence without triggers and the other is testing idempotence with triggers. They are very similar, but clearly not duplicates.

IMO, running anything more than just go fmt on tests is not worth it, since tests often are written in ways that code analyzers are likely to flag. I would look at the linters we have running and see if there's a configuration you can use that gets it to ignore this. I'm not sure why this wasn't flagged in the job resource PR.

Based on the information provided in https://github.com/mibk/dupl?tab=readme-ov-file#dupl, it appears that the golangci-lint will generate duplicate code (dupl errors) for the test cases in job_resource_test.go