Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support symfony 7 #10

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Support symfony 7 #10

merged 2 commits into from
Oct 2, 2024

Conversation

Wiktor6
Copy link
Contributor

@Wiktor6 Wiktor6 commented Sep 30, 2024

AC

  • support symfony 7

@Wiktor6 Wiktor6 requested a review from lukasz-falda October 1, 2024 08:51
lukasz-falda
lukasz-falda approved these changes Oct 1, 2024
View reviewed changes
src/PayPo/Service/Validation.php Outdated
{
if (null === $this->client) {
$this->client = new \GuzzleHttp\Client();
$this->client = new Client();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add timeouts here

@olekans olekans self-requested a review October 1, 2024 13:37
@Wiktor6 Wiktor6 merged commit a852a2c into master Oct 2, 2024
3 checks passed
@Wiktor6 Wiktor6 deleted the support-symfony-7 branch October 2, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olekans olekans olekans approved these changes

@lukasz-falda lukasz-falda lukasz-falda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wiktor6 @lukasz-falda @olekans