(#5652) Added TimeoutSeconds to knative-serving trait #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Jun 18, 2024
hernanDatgDev
force-pushed
the
feature/5652/add-knative-serving-timeout-seconds
branch
from
99c40fc to
6b6158a
Compare
|
I've added a test and squashed the commits as well 👍 |
squakez
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TimeoutSeconds to the knative-serving trait and to the corresponding Knative Revision that is created when using the trait. This field then propagates to
terminationGracePeriodSecondsof the corresponding integration pod. Handles #5652Release Note