[CELEBORN-1081][FOLLOWUP] Remove UNKNOWN_DISK and allocate all slots to disk #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
+ Coverage 46.50% 46.54% +0.04%
==========================================
Files 166 166
Lines 10758 10781 +23
Branches 984 988 +4
==========================================
+ Hits 5002 5017 +15
- Misses 5430 5436 +6
- Partials 326 328 +2 ☔ View full report in Codecov by Sentry. |
…to disk Signed-off-by: mingji <[email protected]>
|
@RexXiong @waitinfuture Take a look at this PR when you have time. |
RexXiong
reviewed
Nov 23, 2023
| diskIndex = (diskIndex + 1) % usableDiskInfos.size(); | ||
| } | ||
| usableDiskInfos.get(diskIndex).usableSlots--; | ||
| DiskInfo selectedDiskInfo = usableDiskInfos.get(diskIndex).diskInfo; |
There was a problem hiding this comment.
IMO, we can put storage type in diskInfo, then we can directly know which type the disk is.
| storageInfo = new StorageInfo(diskInfos[diskIndex].mountPoint(), availableStorageTypes); | ||
| diskIndex = (diskIndex + 1) % diskInfos.length; | ||
| } else { | ||
| storageInfo = new StorageInfo(StorageInfo.Type.HDFS, availableStorageTypes); |
There was a problem hiding this comment.
why use HDFS directly at this branch?
| @@ -218,7 +244,8 @@ private static List<Integer> roundRobin( | |||
| boolean shouldReplicate, | |||
| boolean shouldRackAware, | |||
| int availableStorageTypes) { | |||
| // workerInfo -> (diskIndexForPrimary, diskIndexForReplica) | |||
| // workerInfo -> (diskIndexForPrimary, diskIndexForRe | |||
RexXiong
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
To support the application's config about available storage types.
Does this PR introduce any user-facing change?
no.
How was this patch tested?
GA and Cluster.