Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1054] Support DB based ConfigService #2124

Closed
wants to merge 1 commit into from

Conversation

SteNicholas
Copy link
Member

What changes were proposed in this pull request?

DbConfigServiceImpl supports database based store backend implementation.

Why are the changes needed?

ConfigService interface is introduced for dynamic config at present. Meanwhile, this interface provides FsConfigServiceImpl that is the filesytem store backend. We could support database based store backend implementation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

ConfigServiceSuiteJ

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (8a15396) 47.13% compared to head (32f35ff) 47.51%.

Files Patch % Lines
...ver/common/service/config/DbConfigServiceImpl.java 67.71% 19 Missing and 12 partials ⚠️
...ver/common/service/config/FsConfigServiceImpl.java 50.00% 13 Missing and 3 partials ⚠️
...r/common/service/config/BaseConfigServiceImpl.java 89.48% 1 Missing and 3 partials ⚠️
...rn/server/common/service/config/DynamicConfig.java 60.00% 1 Missing and 1 partial ⚠️
...on/service/config/DynamicConfigServiceFactory.java 66.67% 0 Missing and 1 partial ⚠️
...orn/server/common/service/config/TenantConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   47.13%   47.51%   +0.38%     
==========================================
  Files         173      176       +3     
  Lines       11034    11182     +148     
  Branches     1011     1031      +20     
==========================================
+ Hits         5200     5312     +112     
- Misses       5494     5511      +17     
- Partials      340      359      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteNicholas SteNicholas force-pushed the CELEBORN-1054 branch 3 times, most recently from 1dc4fdf to ac0e9b2 Compare November 30, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant