-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1156][BUILD] SBT publish support #2129
Conversation
docs/developers/sbt.md
Outdated
| SONATYPE_HOST | Sonatype repository host address, default is "oss.sonatype.org" | | ||
| SONATYPE_USERNAME | Sonatype repository username | | ||
| SONATYPE_PASSWORD | Sonatype repository password | | ||
| SONATYPE_SNAPSHOTS_URL | Sonatype repository URL for snapshot version releases, default is "https://oss.sonatype.org/content/repositories/snapshots" | | ||
| SONATYPE_RELEASES_URL | Sonatype repository URL for official release versions, default is "https://oss.sonatype.org/service/local/staging/deploy/maven2" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is SONATYPE_HOST redundant? I suppose SONATYPE_RELEASES_URL and SONATYPE_SNAPSHOTS_URL are sufficient.
For Apache release, the default URL should be https://repository.apache.org/service/local/staging/deploy/maven2 and https://repository.apache.org/content/repositories/snapshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can eliminate SONATYPE_USERNAME, SONATYPE_PASSWORD and simply pick up ASF_USERNAME, ASF_PASSWORD, as they were used in source/binary release process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Apache release, the default URL should be https://repository.apache.org/service/local/staging/deploy/maven2 and https://repository.apache.org/content/repositories/snapshots
do you mean the default values(SONATYPE_SNAPSHOTS_URL/SONATYPE_RELEASES_URL) should be Apache URLs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, we did such thing in another apache projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can eliminate SONATYPE_USERNAME, SONATYPE_PASSWORD and simply pick up ASF_USERNAME, ASF_PASSWORD, as they were used in source/binary release process
done
55d9c51
to
fc03071
Compare
For example: | ||
```shell | ||
export SONATYPE_SNAPSHOTS_URL=http://192.168.3.46:8081/repository/maven-snapshots/ | ||
export SONATYPE_RELEASES_URL=http://192.168.3.46:8081/repository/maven-releases/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the tailing slash matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed in a local environment that the presence or absence of a trailing slash doesn't affect the outcome.
thanks, merging to main(v0.4.0). |
What changes were proposed in this pull request?
As title
Why are the changes needed?
As title
Does this PR introduce any user-facing change?
Yes, the user can publish shade clients via SBT
How was this patch tested?