[CELEBORN-1286] Introduce configuration.md to document dynamic config and config service #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @RexXiong, @AngersZhuuuu. |
SteNicholas
force-pushed
the
CELEBORN-1286
branch
from
ed32050 to
fe64d7d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
+ Coverage 48.76% 48.90% +0.14%
==========================================
Files 207 207
Lines 12939 12939
Branches 1113 1113
==========================================
+ Hits 6309 6327 +18
+ Misses 6221 6207 -14
+ Partials 409 405 -4 ☔ View full report in Codecov by Sentry. |
RexXiong
reviewed
Feb 27, 2024
SteNicholas
force-pushed
the
CELEBORN-1286
branch
from
fe64d7d to
0484edd
Compare
SteNicholas
force-pushed
the
CELEBORN-1286
branch
4 times, most recently
from
4cb5b43 to
a70b027
Compare
pan3793
reviewed
Feb 28, 2024
SteNicholas
force-pushed
the
CELEBORN-1286
branch
3 times, most recently
from
8fa2266 to
e3e6b77
Compare
… and config service
SteNicholas
force-pushed
the
CELEBORN-1286
branch
from
e3e6b77 to
15b36a8
Compare
|
LGTM. Mreged into main(v0.5.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce
configuration.mdto document dynamic config and config service.Why are the changes needed?
DynamicConfigandConfigServicehave already been supported in #2100, which should be documented to introduce the feature.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.