[CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7 #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfmcgrady
commented
Oct 23, 2024
| @@ -347,7 +347,7 @@ object CelebornCommonSettings { | |||
| PB.protocVersion := Dependencies.protocVersion, | |||
| // set proto sources path | |||
| Compile / PB.protoSources := Seq(sourceDirectory.value / "main" / "proto"), | |||
| Compile / PB.targets := Seq(PB.gens.java -> (Compile / sourceManaged).value) | |||
| Compile / PB.targets := Seq(PB.gens.java(Dependencies.protocVersion) -> (Compile / sourceManaged).value) | |||
There was a problem hiding this comment.
The protobuf-java version is required. see thesamet/sbt-protoc#360
SteNicholas
approved these changes
Oct 23, 2024
cxzl25
approved these changes
Oct 23, 2024
|
thanks, merging to main(v0.6.0)/branch-0.5(v0.5.3)/branch-0.4(v0.4.3). |
cfmcgrady
added a commit
that referenced
this pull request
Oct 24, 2024
### What changes were proposed in this pull request? As title ### Why are the changes needed? The version 1.0.6 is outdated and not available on Maven Central. https://mvnrepository.com/artifact/com.thesamet/sbt-protoc_2.12_1.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass CI Closes #2842 from cfmcgrady/sbt-protoc. Authored-by: Fu Chen <[email protected]> Signed-off-by: Fu Chen <[email protected]> (cherry picked from commit 3b9c2f0) Signed-off-by: Fu Chen <[email protected]>
cfmcgrady
added a commit
that referenced
this pull request
Oct 24, 2024
### What changes were proposed in this pull request? As title ### Why are the changes needed? The version 1.0.6 is outdated and not available on Maven Central. https://mvnrepository.com/artifact/com.thesamet/sbt-protoc_2.12_1.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass CI Closes #2842 from cfmcgrady/sbt-protoc. Authored-by: Fu Chen <[email protected]> Signed-off-by: Fu Chen <[email protected]> (cherry picked from commit 3b9c2f0) Signed-off-by: Fu Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title
Why are the changes needed?
The version 1.0.6 is outdated and not available on Maven Central.
https://mvnrepository.com/artifact/com.thesamet/sbt-protoc_2.12_1.0
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass CI