Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 #2898

Closed
wants to merge 2 commits into from
Closed

[CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 #2898

wants to merge 2 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Nov 11, 2024 •
edited
Loading

What changes were proposed in this pull request?

Bump protobuf from 3.21.7 to 3.25.5.

Why are the changes needed?

To fix CVE: GHSA-735f-pc8j-v9w8

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA.

@turboFei turboFei changed the title [CELEBORN-1708] Bump protobuf from 3.21.7 to 3.25.5 [CELEBORN-1708] Bump protobuf version from 3.21.7 to 3.25.5 Nov 11, 2024
@pan3793
Copy link
Member

pan3793 commented Nov 11, 2024

the recent protobuf java versions introduced "runtime jar version" and "generated code version" check, it may affect the case: if we pull a thrid-party dependency that contains the generated protobuf code, we should be careful on bumping protobuf runtime jars version. For the Celeborn case, please also test Ratis gRPC mode when bumping protobuf versions.

@turboFei
Copy link
Member Author

turboFei commented Nov 11, 2024 •
edited
Loading

For ratis:

The protobuf is shaded and the shaded.protobuf.version is 3.24.4 in ratis 3.1.1 and 3.1.2
https://github.com/apache/ratis/blob/45a30d890451a44ec918fdee2732c5fff80ea17c/pom.xml#L216C1-L217C1

Will test celeborn.master.ha.ratis.raft.rpc.type=grpc.

@turboFei
Copy link
Member Author

turboFei commented Nov 11, 2024 •
edited
Loading

@pan3793 how about adding the UT with grpc mode?

The protobuf is shaded in ratis and the shaded.protobuf.version is 3.24.4 in ratis 3.1.1 and 3.1.2.

@pan3793
Copy link
Member

pan3793 commented Nov 11, 2024

it should has no issue if ratis uses a shaded protobuf

pan3793
pan3793 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if CI green

FMX
FMX approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.6.0).

@FMX FMX closed this in 330b2a0 Nov 11, 2024
@turboFei turboFei deleted the bump_protobuf branch November 11, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan3793 pan3793 pan3793 approved these changes

@FMX FMX FMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turboFei @pan3793 @FMX