Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit host tags on KVM #392

Merged
merged 6 commits into from
May 30, 2024
Merged

Implicit host tags on KVM #392

merged 6 commits into from
May 30, 2024

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Apr 18, 2024 •
edited by github-actions bot
Loading

@weizhouapache weizhouapache force-pushed the 4.20-implicit-host-tags branch from bc90953 to def262c Compare April 18, 2024 07:15
@weizhouapache
Copy link
Member Author

Update
https://cloudstack-documentation--392.org.readthedocs.build/en/392/adminguide/host_and_storage_tags.html#host-tags

@weizhouapache
Copy link
Member Author

@shwstppr
I added some lines in this PR. you can find the flexible tags section on same page
we could add more info , do you have advice ?

shwstppr
shwstppr approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache functionality-wise changes look good. Others can review for language/presentation. @rohityadavcloud @DaanHoogland @andrijapanicsb

@andrijapanicsb
Copy link
Contributor

There is no explanation of the implicit host tags here, however it's given in the PR description for the feature.
We need to add it to the docs - at the very least - copy the functionality PR description into this doc PR.

@JoaoJandre
Copy link
Contributor

@weizhouapache It would be good to have a note explaining that flexible tags must always be explicit

@weizhouapache
Copy link
Member Author

@weizhouapache It would be good to have a note explaining that flexible tags must always be explicit

added @JoaoJandre

This was referenced Apr 22, 2024
Merged
Merged
@weizhouapache weizhouapache force-pushed the 4.20-implicit-host-tags branch 13 times, most recently from 19db016 to a038cb8 Compare April 23, 2024 07:50
@weizhouapache weizhouapache force-pushed the 4.20-implicit-host-tags branch from a038cb8 to 0198a68 Compare April 23, 2024 07:57
@weizhouapache weizhouapache force-pushed the 4.20-implicit-host-tags branch from 0198a68 to 1dcbed9 Compare April 23, 2024 08:03
@andrijapanicsb andrijapanicsb self-requested a review April 23, 2024 12:01
andrijapanicsb
andrijapanicsb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud rohityadavcloud marked this pull request as ready for review May 30, 2024 11:52
@rohityadavcloud rohityadavcloud merged commit 3626f28 into apache:main May 30, 2024
1 check passed
@rohityadavcloud rohityadavcloud added this to the 4.20 milestone Jun 5, 2024
GaOrtiga pushed a commit to GaOrtiga/cloudstack-documentation that referenced this pull request Jun 28, 2024
@weizhouapache @andrijapanicsb
Implicit host tags on KVM (apache#392)
e7dd0ad 
* Implicit host tags on KVM

* Update source/adminguide/host_and_storage_tags.rst

Co-authored-by: Andrija Panic <[email protected]>

* Update source/adminguide/host_and_storage_tags.rst

* Update source/adminguide/host_and_storage_tags.rst

* Update source/adminguide/host_and_storage_tags.rst

* Add section

---------

Co-authored-by: Andrija Panic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrijapanicsb andrijapanicsb andrijapanicsb approved these changes

@shwstppr shwstppr shwstppr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weizhouapache @andrijapanicsb @JoaoJandre @shwstppr @rohityadavcloud