Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primera pure patches & various small fixes #10132

Open
wants to merge 53 commits into
base: 4.19
Choose a base branch
from

Conversation

rg9975
Copy link
Contributor

@rg9975 rg9975 commented Dec 21, 2024

Description

This PR...
This PR fixes several small issues with Fiberchannel implementation and locally discovered issues:

  1. volume disconnect timing issues
  2. rescan cleanup script not working correctly
  3. template copy issues
  4. masked/hidden errors and exceptions

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally with real world workloads

How did you try to break this feature and the system with this change?

Tested locally with real world workloads

rg9975 and others added 30 commits March 31, 2024 01:33
rg9975 and others added 19 commits April 29, 2024 20:08
…k returns false during KVMStorageProcessor template copy
…k returns false during KVMStorageProcessor template copy
…storage/motion/StorageSystemDataMotionStrategy.java

Co-authored-by: Suresh Kumar Anaparti <[email protected]>
…ring/module/model/impl/DefaultModuleDefinitionSet.java

Co-authored-by: Suresh Kumar Anaparti <[email protected]>
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 5.20833% with 91 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (ed1b145) to head (3449689).

Files with missing lines Patch % Lines
...rage/datastore/adapter/primera/PrimeraAdapter.java 0.00% 23 Missing ⚠️
...pervisor/kvm/storage/MultipathSCSIAdapterBase.java 0.00% 15 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 11 Missing ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java 0.00% 9 Missing ⚠️
.../spring/lifecycle/CloudStackExtendedLifeCycle.java 0.00% 7 Missing ⚠️
...k/spring/lifecycle/registry/RegistryLifecycle.java 0.00% 6 Missing ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 5 Missing ⚠️
.../subsystem/api/storage/PrimaryDataStoreDriver.java 0.00% 3 Missing ⚠️
...e/cloudstack/storage/volume/VolumeServiceImpl.java 0.00% 3 Missing ⚠️
...er/LibvirtGetUnmanagedInstancesCommandWrapper.java 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10132      +/-   ##
============================================
- Coverage     15.13%   15.12%   -0.01%     
- Complexity    11265    11268       +3     
============================================
  Files          5408     5408              
  Lines        473900   473973      +73     
  Branches      57791    57809      +18     
============================================
+ Hits          71705    71710       +5     
- Misses       394192   394256      +64     
- Partials       8003     8007       +4     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <5.20%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant