-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing the usage of volumeFreeze StorPool API call #8575
base: 4.20
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8575 +/- ##
============================================
- Coverage 30.90% 23.10% -7.80%
+ Complexity 33382 23318 -10064
============================================
Files 5355 5219 -136
Lines 375727 353392 -22335
Branches 54915 50877 -4038
============================================
- Hits 116109 81663 -34446
- Misses 244219 259918 +15699
+ Partials 15399 11811 -3588
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java
Show resolved
Hide resolved
...main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java
Show resolved
Hide resolved
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
573ad8e
to
23e3f20
Compare
23e3f20
to
3bcfaa1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #8575 +/- ##
=========================================
Coverage 16.07% 16.07%
- Complexity 12883 12884 +1
=========================================
Files 5639 5639
Lines 494193 494179 -14
Branches 59925 59919 -6
=========================================
+ Hits 79419 79420 +1
+ Misses 405944 405929 -15
Partials 8830 8830
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ping @slavkap Any further work on this? |
hey @sureshanaparti, no, I think all needed is included |
@blueorangutan package |
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10170 |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
3bcfaa1
to
d099649
Compare
@JoaoJandre, is it possible for this to get in at 4.20? It doesn't affect other storage plugins or CloudStack core; a StorPool API call is deprecated, and this is a cleanup. |
@slavkap , I understand your point, but as this is not fixing a bug and could introduce new ones (as any PR could), I think that it is safer to wait for the next release. From the user perspective, the functionality will not change, right? |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
d099649
to
0e78ba9
Compare
@slavkap @JoaoJandre does it make sense to add this to 4.20.1? |
@DaanHoogland, for me, yes. But I was following the set milestone. Can I rebase it on branch 4.20? |
@slavkap , i see no reason not to, but it is your choice. Last time you were in a freeze for the release, hence @JoaoJandre's reservation. |
0e78ba9
to
3d31305
Compare
Thanks, @DaanHoogland, I moved it to 4.20.1 |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12042 |
.../storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12053 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Description
Deprecate the usage of the volumeFreeze API call.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale