[PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections

[sureshanaparti]

Description

This PR adds & removes PowerFlex/ScaleIO MDM IP addressess while preparing & unpreparing the storage SDC connections (instead of start & stop scini), when powerflex.connect.on.demand is true. And adds & removes MDM IP addresses during Host connection/disconnection to/from storage pool, when powerflex.connect.on.demand is false.

MDMs details persisted using powerflex.storagepool.mdms detail, in storage_pool_details table:

mysql> SELECT * FROM cloud.storage_pool_details WHERE pool_id = 3 AND name = 'powerflex.storagepool.mdms';
+----+---------+---------------------------------+------------------------------------------------------+---------+
| id | pool_id | name                            | value                                                | display |
+----+---------+---------------------------------+------------------------------------------------------+---------+
|  2 |       3 | powerflex.storagepool.mdms      | 10.0.33.178,10.0.33.87                               |       1 |
+----+---------+---------------------------------+------------------------------------------------------+---------+

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested VM start/stop operations, noticed MDMs added/removed in hosts.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 10.02445% with 368 lines in your changes missing coverage. Please review.

Project coverage is 16.09%. Comparing base (fadb39e) to head (3bb0ad0).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...orage/datastore/manager/ScaleIOSDCManagerImpl.java	0.00%	74 Missing ⚠️
...torage/datastore/provider/ScaleIOHostListener.java	0.00%	68 Missing ⚠️
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java	21.62%	25 Missing and 4 partials ⚠️
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	10.34%	25 Missing and 1 partial ⚠️
...re/lifecycle/ScaleIOPrimaryDataStoreLifeCycle.java	33.33%	17 Missing and 3 partials ⚠️
...ck/storage/datastore/api/StorageConfiguration.java	0.00%	19 Missing ⚠️
.../hypervisor/kvm/storage/KVMStoragePoolManager.java	0.00%	17 Missing ⚠️
...cloudstack/storage/datastore/util/ScaleIOUtil.java	50.00%	14 Missing and 2 partials ⚠️
...ore/client/ScaleIOGatewayClientConnectionPool.java	0.00%	14 Missing ⚠️
...a/com/cloud/storage/StoragePoolAutomationImpl.java	0.00%	11 Missing ⚠️
... and 14 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9903      +/-   ##
============================================
- Coverage     16.09%   16.09%   -0.01%     
+ Complexity    12934    12933       -1     
============================================
  Files          5644     5647       +3     
  Lines        494582   494952     +370     
  Branches      59963    60043      +80     
============================================
+ Hits          79622    79645      +23     
- Misses       406124   406457     +333     
- Partials       8836     8850      +14     

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.93% <10.02%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11524

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11772)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58105 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9903-t11772-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	Error	503.38	test_vm_life_cycle.py

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11894

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11910

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11925

[blueorangutan]

[SF] Trillian test result (tid-11979)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53773 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9903-t11979-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_site2site_vpn_multiple_options	Failure	557.77	test_vpc_vpn.py

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[sureshanaparti]

@blueorangutan package

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12049

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12051