Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] CQL_PROHIBITED_CLAUSES_REGEXP to match the "ORDER BY" keyword instead of just "ORDER" #22

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

EnneS
Copy link
Contributor

@EnneS EnneS commented Nov 20, 2023

I encountered an issue where the CQL_PROHIBITED_CLAUSES_REGEXP would match such a request :

SELECT * from trade.orderbyid;

The pattern would match because my table is called orderbyid but it does not include a prohibited SQL clause (ORDER BY in this case).
A simple fix would be to match on the ORDER BY keyword instead of just ORDER which seems more appropriate to me.

Copy link

boring-cyborg bot commented Nov 20, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@EnneS EnneS changed the title Updated CQL_PROHIBITED_CLAUSES_REGEXP to match the "ORDER BY" keyword instead of just "ORDER" [hotfix] CQL_PROHIBITED_CLAUSES_REGEXP to match the "ORDER BY" keyword instead of just "ORDER" Nov 20, 2023
Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It was a typo indeed, thanks for catching it !

@echauchot echauchot merged commit 20c5f50 into apache:main Nov 21, 2023
4 checks passed
Copy link

boring-cyborg bot commented Nov 21, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants