Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-8839] CdcFileGroupIterator use spillable hashmap #12592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[HUDI-8839] CdcFileGroupIterator use spillable hashmap #12592

wants to merge 1 commit into from
+33 −9

Conversation

Davis-Zhang-Onehouse
Copy link
Contributor

@Davis-Zhang-Onehouse Davis-Zhang-Onehouse commented Jan 7, 2025 •
edited
Loading

Change Logs

Change afterImageRecords to use spillable hashmap to mitigate OOM issue.

Impact

CdcFileGroupIterator is less prone to OOM. The default threshold for memory spill is 100MB.

Risk level (write none, low medium or high below)

none

Documentation Update

Added a new configuration hoodie.cdc.file.group.iterator.memory.spill.bytes for overriding default memory spill threshold.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Jan 7, 2025
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:M PR with lines of changes in (100, 300] labels Jan 9, 2025
@Davis-Zhang-Onehouse Davis-Zhang-Onehouse changed the title Hudi 8839 [Hudi-8839] CdcFileGroupIterator use spillable hashmap Jan 9, 2025
@Davis-Zhang-Onehouse Davis-Zhang-Onehouse force-pushed the HUDI-8839 branch 2 times, most recently from 423421e to a5544e3 Compare January 9, 2025 23:13
@Davis-Zhang-Onehouse Davis-Zhang-Onehouse changed the title [Hudi-8839] CdcFileGroupIterator use spillable hashmap [HUDI-8839] CdcFileGroupIterator use spillable hashmap Jan 9, 2025
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Davis-Zhang-Onehouse @hudi-bot