-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-8858]Support ShowRecordLocationProcedure #12599
base: master
Are you sure you want to change the base?
[HUDI-8858]Support ShowRecordLocationProcedure #12599
Conversation
Thanks for your contribution, left some comments. |
import scala.collection.JavaConverters._ | ||
import scala.util.{Failure, Success, Try} | ||
|
||
class ShowRecordLocationProcedure extends BaseProcedure with ProcedureBuilder with Logging { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this procedure only applicable to the bucket index? Can we extend it to all index types? Alternatively, we can add the verification of the bucket index in this pull request (PR) and deal with the remaining index types directly in subsequent pull requests.
private val PARAMETERS = Array[ProcedureParameter]( | ||
ProcedureParameter.required(0, "table", DataTypes.StringType), | ||
ProcedureParameter.required(1, "partition_path", DataTypes.StringType), | ||
ProcedureParameter.required(2, "record_key", DataTypes.StringType), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it support multiple record keys?
The task is not minor, can you create a JIRA task to trace it. |
Nice work! |
Change Logs
Add show record location procedure feature , The pr is aim to locate the bucket id and then the hdfs data file through the record key, it is faster compared to select ${record_key} from table.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist