simply code

apache · Jan 9, 2025 · 5881bc4 · 5881bc4
1 parent db3a9e2
commit 5881bc4
Showing 1 changed file with 2 additions and 19 deletions.
diff --git a/cpp-ch/local-engine/Functions/SparkFunctionCheckDecimalOverflow.cpp b/cpp-ch/local-engine/Functions/SparkFunctionCheckDecimalOverflow.cpp
@@ -178,25 +178,8 @@ class FunctionCheckDecimalOverflow : public IFunction
         {
             ToFieldType result;
             bool success = convertToDecimalImpl<FromDataType, ToDataType>(datas[i], precision, scale_from, scale_to, decimal_int_part_max, decimal_int_part_min, result);
-
-            if constexpr (IsDataTypeNumber<FromDataType>)
-            {
-                vec_to[i] = static_cast<ToFieldType>(result);
-                (*vec_null_map_to)[i] = !success;
-            }
-            else
-            {
-                if (success)
-                    vec_to[i] = static_cast<ToFieldType>(result);
-                else
-                {
-                    vec_to[i] = static_cast<ToFieldType>(0);
-                    if constexpr (exception_mode == CheckExceptionMode::Null)
-                        (*vec_null_map_to)[i] = static_cast<UInt8>(1);
-                    else
-                        throw Exception(ErrorCodes::DECIMAL_OVERFLOW, "Decimal value is overflow.");
-                }
-            }
+            vec_to[i] = static_cast<ToFieldType>(result);
+            (*vec_null_map_to)[i] = !success;
         }
 
         if constexpr (exception_mode == CheckExceptionMode::Null)