Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove an out-of-date warning message #8447

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Jan 7, 2025

This is a follow-up minor fix for #7845.

Enabling Velox background IO thread now no longer causes hanging or dead lock issues. Remove the related warning message which could be misleading for users.

Also, simplify gluten-it option --collect-sql-metrics which is introduced in #8445 to --sql-metrics.

@github-actions github-actions bot added the VELOX label Jan 7, 2025
@apache apache deleted a comment from github-actions bot Jan 7, 2025
@zhztheplayer zhztheplayer changed the title [VL] Remove a out-of-date warning message [VL] Remove an out-of-date warning message Jan 7, 2025
Copy link
Contributor

@zhli1142015 zhli1142015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@apache apache deleted a comment from github-actions bot Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Run Gluten Clickhouse CI on x86

Copy link

github-actions bot commented Jan 7, 2025

Run Gluten Clickhouse CI on x86

@zhztheplayer zhztheplayer merged commit fe02fee into apache:main Jan 7, 2025
48 of 49 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_01_07_2025_time.csv log/native_master_01_07_2025_af559452a8_time.csv difference percentage
q1 16.14 15.47 -0.665 95.88%
q2 17.02 16.61 -0.412 97.58%
q3 2.90 4.97 2.076 171.65%
q4 85.45 81.68 -3.767 95.59%
q5 12.79 12.30 -0.490 96.17%
q6 4.60 4.98 0.383 108.34%
q7 6.73 8.31 1.575 123.39%
q8 4.81 4.46 -0.352 92.69%
q9 28.44 27.04 -1.396 95.09%
q10 12.79 13.35 0.558 104.36%
q11 42.52 42.13 -0.389 99.09%
q12 1.96 2.33 0.366 118.64%
q13 8.25 8.12 -0.130 98.42%
q14a 61.76 64.25 2.489 104.03%
q14b 58.31 56.48 -1.828 96.86%
q15 3.32 3.54 0.227 106.84%
q16 29.25 28.50 -0.757 97.41%
q17 7.73 7.58 -0.147 98.10%
q18 10.09 9.25 -0.836 91.71%
q19 3.68 3.72 0.041 101.11%
q20 2.39 2.66 0.272 111.41%
q21 1.50 1.52 0.022 101.45%
q22 9.23 9.71 0.473 105.12%
q23a 135.52 136.27 0.751 100.55%
q23b 163.30 164.80 1.503 100.92%
q24a 105.68 88.25 -17.433 83.50%
q24b 96.70 88.18 -8.518 91.19%
q25 6.50 6.62 0.127 101.96%
q26 3.98 4.95 0.971 124.39%
q27 4.58 5.13 0.552 112.07%
q28 37.08 38.09 1.013 102.73%
q29 17.48 16.86 -0.612 96.50%
q30 6.63 6.05 -0.571 91.38%
q31 10.65 11.03 0.378 103.55%
q32 2.08 3.54 1.462 170.37%
q33 7.52 6.89 -0.638 91.53%
q34 4.27 7.10 2.831 166.27%
q35 12.20 10.46 -1.735 85.78%
q36 5.41 5.52 0.107 101.97%
q37 5.32 5.26 -0.055 98.97%
q38 18.16 18.02 -0.146 99.20%
q39a 4.47 5.01 0.542 112.14%
q39b 5.05 4.76 -0.292 94.21%
q40 6.29 5.10 -1.190 81.09%
q41 0.89 0.90 0.015 101.71%
q42 1.51 1.18 -0.334 77.95%
q43 4.50 4.64 0.143 103.18%
q44 12.47 11.80 -0.671 94.62%
q45 4.19 5.50 1.309 131.26%
q46 5.78 5.36 -0.419 92.76%
q47 20.34 19.89 -0.450 97.79%
q48 6.78 6.65 -0.130 98.08%
q49 11.00 10.16 -0.845 92.32%
q50 38.42 35.97 -2.449 93.63%
q51 14.67 14.85 0.186 101.27%
q52 1.38 1.29 -0.093 93.27%
q53 3.31 3.06 -0.256 92.28%
q54 6.80 7.13 0.336 104.95%
q55 1.28 1.42 0.140 110.88%
q56 7.13 7.11 -0.020 99.72%
q57 13.29 12.59 -0.703 94.71%
q58 3.43 3.35 -0.087 97.47%
q59 7.14 6.98 -0.158 97.79%
q60 8.96 8.87 -0.089 99.00%
q61 7.73 9.00 1.270 116.44%
q62 5.09 5.47 0.378 107.43%
q63 3.20 3.22 0.021 100.65%
q64 62.56 62.39 -0.173 99.72%
q65 29.84 30.33 0.498 101.67%
q66 4.31 4.36 0.056 101.30%
q67 228.28 233.24 4.961 102.17%
q68 4.47 3.98 -0.490 89.04%
q69 7.78 6.71 -1.074 86.20%
q70 13.06 12.88 -0.178 98.63%
q71 6.04 5.65 -0.388 93.58%
q72 38.45 38.28 -0.173 99.55%
q73 3.45 3.11 -0.342 90.10%
q74 26.70 26.51 -0.193 99.28%
q75 43.85 40.96 -2.895 93.40%
q76 14.17 14.95 0.780 105.51%
q77 4.13 4.25 0.120 102.90%
q78 84.42 84.76 0.341 100.40%
q79 5.28 5.71 0.433 108.21%
q80 16.95 17.20 0.247 101.46%
q81 8.49 7.82 -0.664 92.17%
q82 10.13 10.28 0.151 101.49%
q83 2.58 2.75 0.166 106.43%
q84 3.59 3.70 0.108 103.00%
q85 9.86 9.83 -0.035 99.64%
q86 4.57 4.88 0.311 106.81%
q87 18.85 18.13 -0.717 96.19%
q88 23.24 23.25 0.009 100.04%
q89 4.68 4.34 -0.336 92.81%
q90 3.30 3.24 -0.057 98.26%
q91 5.51 5.07 -0.438 92.05%
q92 2.15 2.11 -0.037 98.30%
q93 54.10 52.80 -1.296 97.60%
q94 16.93 17.49 0.558 103.30%
q9 97.68 151.61 53.925 155.20%
q5 3.01 5.56 2.553 184.75%
q96 28.58 28.13 -0.446 98.44%
q97 2.75 5.02 2.266 182.29%
q98 10.63 10.59 -0.035 99.67%
q99 10.63 10.59 -0.035 99.67%
total 2184.16 2215.13 30.976 101.42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants