[GLUTEN_8475][VL] Fix C-style casts to C++-style #8474
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
jkhaliqi
changed the title
jkhaliqi
changed the title
cpp/core/memory/MemoryAllocator.cc
Outdated
| @@ -161,7 +161,7 @@ bool StdMemoryAllocator::reallocateAligned(void* p, uint64_t alignment, int64_t | |||
| return false; | |||
| } | |||
| if (newSize <= size) { | |||
| auto aligned = ROUND_TO_LINE(newSize, alignment); | |||
| auto aligned = ROUND_TO_LINE(static_cast<uint64_t> newSize, alignment); | |||
There was a problem hiding this comment.
Dont Use Cast@cpp/core/memory/MemoryAllocator.cc:164
looks like newSize is int64_t and alignment is uint64_t so i'm assuming there is some sort of casting that goes on when calling this function. With that I figured they should both go in with the same type. With the above line showing if (newSize <= 0) {return false;} im assuming newSize will be positive if it gets to here so I just casted it to be uint64_t like the alignment variable
There was a problem hiding this comment.
sorry I did forget the parenthesis around newSize, updating!
There was a problem hiding this comment.
I see, thanks.
It seems GitHub CI service is encountering issues so the CI is not triggering BTW.
What changes were proposed in this pull request?
False positives for Do not Cast
cpp/velox/compute/WholeStageResultIterator.cc:461
cpp/velox/compute/WholeStageResultIterator.cc:463](http://wholestageresultiterator.cc:463/)
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:219
cpp/velox/tests/FunctionTest.cc:157
cpp/velox/shuffle/VeloxShuffleReader.cc:437
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:347
cpp/velox/substrait/SubstraitToVeloxPlan.cc:1049
cpp/velox/substrait/SubstraitToVeloxPlan.cc:1040
cpp/velox/substrait/SubstraitToVeloxPlan.cc:1102
cpp/velox/substrait/SubstraitToVeloxPlan.cc:1095
(Please fill in changes proposed in this fix)
(Fixes: #8475)