-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: duplicate image row for update join #5004
bugfix: duplicate image row for update join #5004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #5004 +/- ##
=============================================
+ Coverage 48.81% 48.82% +0.01%
Complexity 4079 4079
=============================================
Files 733 733
Lines 25951 25962 +11
Branches 3199 3201 +2
=============================================
+ Hits 12669 12677 +8
- Misses 11933 11936 +3
Partials 1349 1349
|
按照 http://dev.cs.ovgu.de/db/sybase9/help/dbugen9/00000284.htm 规范来说,groupby pk是不符合规范的,但是groupby所有查询列的做法可能在前镜像查询的时候造成负担(前镜像的where条件不一定命中索引) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/exec/mysql/MySQLUpdateJoinExecutor.java
Outdated
Show resolved
Hide resolved
seata-go: apache/incubator-seata-go#703 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews