Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: delete unnecessary cached data #6988

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

optimize: delete unnecessary cached data #6988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a795f
optimize: delete unnecessary cached data
MaoMaoandSnail Nov 7, 2024
cc1d1ad
Merge branch '2.x' into delete_unnecessary_cached_data
xingfudeshi Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...gine/src/main/java/org/apache/seata/saga/engine/repo/impl/StateMachineRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ public StateMachine getStateMachineById(String stateMachineId) {
stateMachine.setStartState(parsedStatMachine.getStartState());
stateMachine.getStates().putAll(parsedStatMachine.getStates());
item.setValue(stateMachine);
stateMachineMapById.put(stateMachine.getName() + "_" + stateMachine.getTenantId(),
item);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not currently in use, but you are not advised to delete the tenant information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not currently in use, but you are not advised to delete the tenant information.

Name+tenantId 是一个隐式的主键,按道理说是可以放在stateMachineMapById中,但是我们这里放进去之后,首先其他地方并没有调用该缓存,并且其他地方缓存数据时,也并没有将Name+tenantId作为隐式主键放到stateMachineMapById中,而是分开存储,只有这个地方单独处理,我觉的应该统一方式,要处理就都处理,要不处理就都不处理,不然容易让人产生困惑
Name+tenantId is an implicit primary key and could theoretically be stored in stateMachineMapById. However, after adding it here, other parts of the system do not call this cache, nor do they use Name+tenantId as an implicit primary key when storing data in stateMachineMapById. Instead, they store the data separately. This is the only place where it is handled individually. I believe the approach should be unified: either handle it everywhere or not handle it at all; otherwise, it may cause confusion.

}
}
}
Expand Down
Loading