-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Plexus DI mentions #646
base: master
Are you sure you want to change the base?
Conversation
[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns. | ||
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling. | ||
|
||
[[7]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is not used anywhere in the file. Accidentally forgotten to actual use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood the link list as further information.
Nevertheless my changes have another focus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this if it's not used. Links are for citations, not further reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @elharo, for your feedback.
As I described above, the focus of my PR is about Plexus DI.
Nevertheless, I think we have now two options:
- I will open a new PR to address your findings, and please let us focus on the PR topic.
- I will extend the focus of my PR, but we should define the focus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened another PR to clean up a lot of this. This page does seem to need some editing. Thanks.
|
||
[[5]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling. | ||
[[5]] {{{https://codehaus-plexus.github.io/plexus-utils/}Plexus Common Utilities}}: Set of utilities classes useful for Mojo development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utilities classes --> utility classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment above
|
||
[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns. | ||
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this: it's not part of maven, IMHO not well maintained, and we probably should not recommend it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment above
[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns. | ||
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling. | ||
|
||
[[7]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this if it's not used. Links are for citations, not further reading
During browsing documentation how to use JSR 330 and Sisu during the plugin development, I found mentions to Plexus DI.