Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Plexus DI mentions #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sparsick
Copy link
Contributor

During browsing documentation how to use JSR 330 and Sisu during the plugin development, I found mentions to Plexus DI.

[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns.
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling.

[[7]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not used anywhere in the file. Accidentally forgotten to actual use it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood the link list as further information.

Nevertheless my changes have another focus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this if it's not used. Links are for citations, not further reading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elharo, for your feedback.

As I described above, the focus of my PR is about Plexus DI.

Nevertheless, I think we have now two options:

  1. I will open a new PR to address your findings, and please let us focus on the PR topic.
  2. I will extend the focus of my PR, but we should define the focus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened another PR to clean up a lot of this. This page does seem to need some editing. Thanks.

elharo
elharo previously requested changes Jan 19, 2025

[[5]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling.
[[5]] {{{https://codehaus-plexus.github.io/plexus-utils/}Plexus Common Utilities}}: Set of utilities classes useful for Mojo development.
Copy link
Contributor

@elharo elharo Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilities classes --> utility classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above


[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns.
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this: it's not part of maven, IMHO not well maintained, and we probably should not recommend it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above

[[6]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns.
[[6]] {{{http://commons.apache.org/io/}Commons IO}}: Set of utilities classes useful for file/path handling.

[[7]] {{{../../plugin-developers/common-bugs.html}Common Bugs and Pitfalls}}: Overview of problematic coding patterns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this if it's not used. Links are for citations, not further reading

@sparsick sparsick requested a review from elharo January 20, 2025 11:41
@elharo elharo dismissed their stale review January 20, 2025 12:36

doing elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants