Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-12043. Mark fixed column with disabled checkbox #7667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-12043. Mark fixed column with disabled checkbox.

Please describe your PR in detail:

  • In MultiSelect component, we pass a fixedColumn prop which decides the menu option which should not be selectable. This is useful to make table have at-least one column fixed even if other columns are deselected.
  • But in the current implementation this disabled option is rendered with an active checkbox causing the confusion that the option is selectable.
  • This PR modifies the option passed to have isDisabled explicitly set for fixedColumn and use that as the options to the menu.
  • This will render the fixedColumn with a grey disabled checkbox, which provides proper feedback to the user that the column is not selected/fixed.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12043

How was this patch tested?

Patch was tested manually
Before the changes:
Screenshot 2025-01-08 at 20 54 20

After the changes:
Screenshot 2025-01-08 at 20 54 56

Same has been tested out for the Pipelines page, Volumes page and Containers page i.e wherever fixedColumn is being passed to MultiSelect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants