HDDS-11590. Use JSON to pass config for docker #7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using env vars with non-compliant names we will use variables with JSON describing all necessary configuration files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of using env vars with non-compliant names we will use variables with JSON describing all necessary configuration files.
Please describe your PR in detail:
In this PR proposed to change our approach on describing cluster configuration for our Docker images.
Right now we are using a lot of environment variables with non-compliant names. Which in turn sometimes leads to situations where all our Docker infrastructure is not working thanks to changes on the Docker side.
Instead it is better to describe configurations using JSON format.
In the first implementation it is just a straight replacement of many env vars with one containing JSON. However later we can move all configurations into separate JSON files so we can have better control on what actually resides in all these configuration properties.
Changes are backward compatible with the old format.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11590
How was this patch tested?
Patch tested using CI