RATIS-2220. Skip further tests after leak detected (#1193)

apache · Dec 23, 2024 · ee56932 · ee56932
1 parent 551b8c9
commit ee56932
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/ratis-common/src/main/java/org/apache/ratis/util/LeakDetector.java b/ratis-common/src/main/java/org/apache/ratis/util/LeakDetector.java
@@ -156,6 +156,10 @@ Runnable track(Object leakable, Supplier<String> reportLeak) {
     return trackers.add(leakable, queue, reportLeak)::remove;
   }
 
+  public int getLeakCount() {
+    return trackers.getNumLeaks(false);
+  }
+
   public void assertNoLeaks(int maxRetries, TimeDuration retrySleep) throws InterruptedException {
     synchronized (leakMessages) {
       // leakMessages are all the leaks discovered so far.

diff --git a/ratis-common/src/test/java/org/apache/ratis/BaseTest.java b/ratis-common/src/test/java/org/apache/ratis/BaseTest.java
@@ -22,6 +22,7 @@
 import org.apache.ratis.util.ExitUtils;
 import org.apache.ratis.util.FileUtils;
 import org.apache.ratis.util.JavaUtils;
+import org.apache.ratis.util.ReferenceCountedLeakDetector;
 import org.apache.ratis.util.Slf4jUtils;
 import org.apache.ratis.util.StringUtils;
 import org.apache.ratis.util.TimeDuration;
@@ -30,6 +31,7 @@
 import org.junit.Rule;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Assumptions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.TestInfo;
 import org.junit.jupiter.api.Timeout;
@@ -97,6 +99,9 @@ public void setup(TestInfo testInfo) {
     testCaseName = testInfo.getTestMethod()
         .orElseThrow(() -> new RuntimeException("Exception while getting test name."))
         .getName();
+
+    final int leaks = ReferenceCountedLeakDetector.getLeakDetector().getLeakCount();
+    Assumptions.assumeFalse(0 < leaks, () -> "numLeaks " + leaks + " > 0");
   }
 
   // @After annotation is retained to support junit 4 tests.